I often notice during my initial meetings with clients that they expect me to be a "yes (wo)man."
When they tell me their story and ask me if they have a good case, they want me to tell them: "Yes!"
When they ask if a judge or jury will award them the significant financial award that they want, they want me to tell them: "Of course, you may even get more than that because the other person is such a bad guy!"
When they tell me how their spouse cheated with their best friend, they want me to tell them: "He will never see the kids again!"
If your attorney is saying yes to these questions, without more, you should go out and hire a new attorney because they are doing you a disservice by not being both your adviser and your advocate. I have yet to meet a client who is 100% right, 100% of the time. Moreover, there is risk involved in every case whether it is a civil, criminal or family law matter. After hearing the facts of your case, your attorney should advise you about what the law is, how it should be applied in your case and what the potential ranges of outcome are. Attorneys are not psychic and no one can predict what will happen in your case with 100% certainty. You should expect that your attorney will tell you about the strengths of your case as well as the weaknesses. The same goes for the other side's case - your attorney should talk to you about the strengths and weaknesses of their arguments.
When you meet with your attorney one-on-one, the communication is confidential. This is the time when you want to hear these things. It does not mean that your attorney does not believe in you or won't fight for you in court. You don't want the first time that you realize that there is a weakness in your case to be when you are testifying before a judge or jury. Talking about your case realistically with your attorney will allow you to put together the best legal strategy that you can. Once you have done this, and you walk into the courtroom, that is when your attorney should be your advocate.